linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-am65*: remove #address-cells/#size-cells from flash nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61bec34c-0861-f042-09bd-d30fd0cafb8f@siemens.com>
Date:   Thu, 3 Feb 2022 13:52:15 +0100
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65*: remove
 #address-cells/#size-cells from flash nodes

On 11.01.22 12:25, Matthias Schiffer wrote:
> Specifying partitions directly in the flash node is deprecated, a
> fixed-partitions node should be used instead. Therefore, it doesn't make
> sense to have these properties in the flash nodes.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 --
>  arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 8 ++------
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 873c123c611e..7eca697e1ca1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -623,8 +623,6 @@ flash@0 {
>  		cdns,tchsh-ns = <60>;
>  		cdns,tslch-ns = <60>;
>  		cdns,read-delay = <2>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 821ee7f2eff0..9c06da9d6d8f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -340,14 +340,12 @@ &main_spi0 {
>  	ti,pindir-d0-out-d1-in;
>  	status = "okay";
>  
> -	flash@0{
> +	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0x0>;
>  		spi-tx-bus-width = <1>;
>  		spi-rx-bus-width = <1>;
>  		spi-max-frequency = <48000000>;
> -		#address-cells = <1>;
> -		#size-cells= <1>;
>  	};
>  };
>  
> @@ -442,7 +440,7 @@ &ospi0 {
>  	pinctrl-0 = <&mcu_fss0_ospi0_pins_default>;
>  	status = "okay";
>  
> -	flash@0{
> +	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0x0>;
>  		spi-tx-bus-width = <8>;
> @@ -453,8 +451,6 @@ flash@0{
>  		cdns,tchsh-ns = <60>;
>  		cdns,tslch-ns = <60>;
>  		cdns,read-delay = <0>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  	};
>  };
>  

For the iot2050 bits:

Acked-by: Jan Kiszka <jan.kiszka@...mens.com>

-- 
Siemens AG, Technology
Competence Center Embedded Linux