linux-kernel - Re: [PATCH 1/2] arm64: dts: ti: k3-am65: disable optional peripherals by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 03 Feb 2022 14:06:20 +0100
From:   Matthias Schiffer <matthias.schiffer@...tq-group.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>, Nishanth Menon <nm@...com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65: disable optional
 peripherals by default

On Thu, 2022-02-03 at 12:39 +0100, Jan Kiszka wrote:
> On 02.02.22 21:32, Nishanth Menon wrote:
> > On 12:25-20220111, Matthias Schiffer wrote:
> > > All peripharals that require pinmuxing or other configuration to
> > > work
> > > should be disabled by default. Dependent DTS are adjusted
> > > accordingly.
> > > 
> > > The following nodes are now "disabled" according to dtx_diff and
> > > were not
> > > overridden to "okay", as they define no pinctrl:
> > > 
> > > k3-am654-base-board:
> > > - mcu_i2c0
> > > - mcu_spi0..2
> > > - cal
> > > - main_i2c3
> > > - ehrpwm0..5
> > > - main_uart1..2
> > > - main_spi1..4
> > > 
> > > k3-am65-iot2050*:
> > > - mci_spi1..2
> > > - cal
> > > - ehrpwm0..5
> > > - main_spi0..4
> > > 
> > > Signed-off-by: Matthias Schiffer <
> > > matthias.schiffer@...tq-group.com>
> > 
> > Jan: you ok with this series? Please ack.
> > 
> 
> Just rebased the still-too-long backlog to our system fully working
> over 
> mainline.

Thanks for testing. As noted earlier, I will send a v2 of this patch
that fixes one more inconsistency.

> Basically looks good, but this might be a regression of the 
> patch:
> 
> [    1.810083] OF: /bus@...000/pcie@...0000: phandle pcie-mode@...0
> needs 1, found 0
> ...
> [    1.854840] OF: /bus@...000/pcie@...0000: phandle pcie-devid@210
> needs 1, found 0
> 
> Jan
> 

That seems to be an older issue, rather than a regression of this
patch:

k3-am65-main.dtsi defines:

    ti,syscon-pcie-id = <&pcie_devid>;
    ti,syscon-pcie-mode = <&pcie0_mode>

While according the driver binding docs something like the following is
expected:

    ti,syscon-pcie-id = <&scm_conf 0x0210>;
    ti,syscon-pcie-mode = <&scm_conf 0x4060>;

I assume that the k3-am65-main.dtsi section was imported from ti-linux
without accounting for the mainline driver's different binding.

Matthias