lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Feb 2022 14:47:13 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Thomas Zimmermann <tzimmermann@...e.de> Cc: Daniel Vetter <daniel.vetter@...ll.ch>, DRI Development <dri-devel@...ts.freedesktop.org>, Intel Graphics Development <intel-gfx@...ts.freedesktop.org>, Linux Fbdev development list <linux-fbdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Daniel Vetter <daniel.vetter@...el.com>, Daniel Vetter <daniel@...ll.ch>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Du Cheng <ducheng2@...il.com>, Claudio Suarez <cssk@...-c.es> Subject: Re: [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean On Wed, Feb 2, 2022 at 10:25 AM Thomas Zimmermann <tzimmermann@...e.de> wrote: > Am 31.01.22 um 22:05 schrieb Daniel Vetter: > > It's only one flag and slightly tidier code. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@...el.com> > > Cc: Daniel Vetter <daniel@...ll.ch> > > Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > > Cc: Du Cheng <ducheng2@...il.com> > > Cc: Thomas Zimmermann <tzimmermann@...e.de> > > Cc: Claudio Suarez <cssk@...-c.es> > > Acked-by: Thomas Zimmermann <tzimmermann@...e.de> > > +++ b/drivers/video/fbdev/core/fbcon.h > > @@ -18,8 +18,6 @@ > > > > #include <asm/io.h> > > > > -#define FBCON_FLAGS_INIT 1 > > - > > /* > > * This is the interface between the low-level console driver and the > > * low-level frame buffer device > > @@ -77,7 +75,7 @@ struct fbcon_ops { > > int blank_state; > > int graphics; > > int save_graphics; /* for debug enter/leave */ > > - int flags; > > + bool initialized; > > This will add 3 bytes of padding. Maybe you can put the bool elsewhere. Several of the int variables are used as boolean flags, too. Perhaps convert them all to bitfields? unsigned int initialized : 1; ... > > int rotate; > > int cur_rotate; > > char *cursor_data; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists