linux-kernel - Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <962dc65c-6e52-bf02-5ba5-7e8731442390@oracle.com>
Date:   Thu, 3 Feb 2022 16:46:44 +0100
From:   William Roche <william.roche@...cle.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Yazen Ghannam <yazen.ghannam@....com>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, mchehab@...nel.org,
        tony.luck@...el.com, james.morse@....com, rric@...nel.org,
        Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM

On 03/02/2022 15:09, Borislav Petkov wrote:

> On Thu, Feb 03, 2022 at 02:19:19PM +0100, William Roche wrote:
>> As we are moving the dram_type cached date from pvt to umc for family >=
>> 0x17, should we also add a small comment for the dram_type field in the
>> amd64_pvt structure to indicate that ?
> Who would be that comment for? People who are looking at the code, so
> that they know which is which?

Yes, it could be a hint about the use case of this field.
Of course we could be more complete and also comment the umc field use 
in this same structure that depends on the family higher or lower than 
17 too.
But I had the impression that the creation of a new dram_type cache 
field would be clarified by a comment on the old location, that's it.
It's up to Yazen and you to include or not  this small addition about 
dram_type.

>
>> Something like that for example:
>>
>> @@ -385,7 +385,7 @@
>>       /* place to store error injection parameters prior to issue */
>>       struct error_injection injection;
>>
>> -    /* cache the dram_type */
>> +    /* cache the dram_type for family<0x17 */
>>       enum mem_type dram_type;
>>
>>       struct amd64_umc *umc;    /* UMC registers */
>>
>>
>> Just a suggestion.
>> The code looks good to me.
>>
>> Reviewed-by: William Roche <william.roche@...cle.com>
>>
>> W.
> Btw, I'd appreciate it if you do not top-post.
>
> Thx.

Sure, sorry.