linux-kernel - Re: [PATCH v2 1/4] clk: actions: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Feb 2022 21:42:10 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Andreas Färber <afaerber@...e.de>,
        Saravanan Sekar <sravanhome@...il.com>,
        Parthiban Nallathambi <pn@...x.de>,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] clk: actions: Terminate clk_div_table with
 sentinel element

On Thu, Feb 03, 2022 at 03:21:50PM +0100, Jonathan Neuschäfer wrote:
> In order that the end of a clk_div_table can be detected, it must be
> terminated with a sentinel element (.div = 0).
> 
> Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support")
> Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
> 
> I'm not so sure about usb3_mac_div_table. Maybe the { 0, 8 } element was
> meant to be { 0, 0 }? I'd appreciate if someone with access to the
> datasheet or hardware could verify what's correct.

USB3 factor table is not documented in the datasheet I have access to. But by
looking at the value, it looks to be a typo. So please change the last entry.
With that,

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks,
Mani

> 
> v2:
> - Add Fixes tags
> ---
>  drivers/clk/actions/owl-s700.c | 1 +
>  drivers/clk/actions/owl-s900.c | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s700.c
> index a2f34d13fb543..617174644f728 100644
> --- a/drivers/clk/actions/owl-s700.c
> +++ b/drivers/clk/actions/owl-s700.c
> @@ -162,6 +162,7 @@ static struct clk_div_table hdmia_div_table[] = {
> 
>  static struct clk_div_table rmii_div_table[] = {
>  	{0, 4},   {1, 10},
> +	{0, 0},
>  };
> 
>  /* divider clocks */
> diff --git a/drivers/clk/actions/owl-s900.c b/drivers/clk/actions/owl-s900.c
> index 790890978424a..f6f49100a865b 100644
> --- a/drivers/clk/actions/owl-s900.c
> +++ b/drivers/clk/actions/owl-s900.c
> @@ -139,8 +139,8 @@ static struct clk_div_table rmii_ref_div_table[] = {
>  };
> 
>  static struct clk_div_table usb3_mac_div_table[] = {
> -	{ 1, 2 }, { 2, 3 }, { 3, 4 },
> -	{ 0, 8 },
> +	{ 1, 2 }, { 2, 3 }, { 3, 4 }, { 0, 8 },
> +	{ 0, 0 },
>  };
> 
>  static struct clk_div_table i2s_div_table[] = {
> --
> 2.34.1
>