linux-kernel - Re: [PATCH v2 1/4] clk: actions: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf29Wt6DGYxDUlDj@latitude>
Date:   Sat, 5 Feb 2022 00:57:14 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Manivannan Sadhasivam <mani@...nel.org>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Andreas Färber <afaerber@...e.de>,
        Saravanan Sekar <sravanhome@...il.com>,
        Parthiban Nallathambi <pn@...x.de>,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] clk: actions: Terminate clk_div_table with
 sentinel element

On Thu, Feb 03, 2022 at 09:42:10PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Feb 03, 2022 at 03:21:50PM +0100, Jonathan Neuschäfer wrote:
> > In order that the end of a clk_div_table can be detected, it must be
> > terminated with a sentinel element (.div = 0).
> > 
> > Fixes: d47317ca4ade1 ("clk: actions: Add S700 SoC clock support")
> > Fixes: d85d20053e195 ("clk: actions: Add S900 SoC clock support")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > ---
> > 
> > I'm not so sure about usb3_mac_div_table. Maybe the { 0, 8 } element was
> > meant to be { 0, 0 }? I'd appreciate if someone with access to the
> > datasheet or hardware could verify what's correct.
> 
> USB3 factor table is not documented in the datasheet I have access to. But by
> looking at the value, it looks to be a typo. So please change the last entry.

Okay.

> With that,
> 
> Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks!

Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)