linux-kernel - Re: [PATCH v18 2/4] dmaengine: tegra: Add tegra gpcdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6d70e52-a984-d973-f3bb-f70f1a4ce95d@gmail.com>
Date:   Thu, 3 Feb 2022 21:22:49 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Rajesh Gumasta <rgumasta@...dia.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>
Cc:     Pavan Kunapuli <pkunapuli@...dia.com>
Subject: Re: [PATCH v18 2/4] dmaengine: tegra: Add tegra gpcdma driver

03.02.2022 06:44, Akhil R пишет:
>> But why do you need to pause at all here and can't use
>> tegra_dma_stop_client() even if pause is supported?
> The recommended method to terminate a transfer in
> between is to pause the channel first and then disable it.
> This is more graceful and stable for the hardware.
> stop_client() is more abrupt, though it does the job.

If there is no real practical difference, then I'd use the common method
only. This will make code cleaner and simpler a tad.