linux-kernel - Re: [PATCH] random: remove use_input_pool parameter from crng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qNcggYVdEK3AmOZFfWmHyFb5WTF6Q8ubyHKE5b=8GPFA@mail.gmail.com>
Date:   Fri, 4 Feb 2022 23:56:15 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: remove use_input_pool parameter from crng_reseed()

Hey Eric,

On Fri, Feb 4, 2022 at 11:18 PM Eric Biggers <ebiggers@...nel.org> wrote:
> The primary_crng is always reseeded from the input_pool, while the NUMA
> crngs are always reseeded from the primary_crng.  Remove the redundant
> 'use_input_pool' parameter from crng_reseed() and just directly check
> whether the crng is the primary_crng.

Nice simplification, thanks.

Jason