linux-kernel - Re: [PATCH] random: remove use_input_pool parameter from crng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf4lyqaPOxGoG8/q@owl.dominikbrodowski.net>
Date:   Sat, 5 Feb 2022 08:22:50 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     "Jason A . Donenfeld " <Jason@...c4.com>,
        Theodore Ts'o <tytso@....edu>, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: remove use_input_pool parameter from
 crng_reseed()

Am Fri, Feb 04, 2022 at 02:17:33PM -0800 schrieb Eric Biggers:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The primary_crng is always reseeded from the input_pool, while the NUMA
> crngs are always reseeded from the primary_crng.  Remove the redundant
> 'use_input_pool' parameter from crng_reseed() and just directly check
> whether the crng is the primary_crng.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

	Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net>

Thanks,
	Dominik