linux-kernel - Re: [PATCH v3 2/4] clk: loongson1: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Feb 2022 13:59:39 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Philippe Mathieu-Daudé <f4bug@...at.org>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        Keguang Zhang <keguang.zhang@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Yang Ling <gnaygnil@...il.com>
Subject: Re: [PATCH v3 2/4] clk: loongson1: Terminate clk_div_table with
 sentinel element

On Sat, Feb 05, 2022 at 01:17:10PM +0100, Philippe Mathieu-Daudé wrote:
> On 5/2/22 01:52, Jonathan Neuschäfer wrote:
> > In order that the end of a clk_div_table can be detected, it must be
> > terminated with a sentinel element (.div = 0).
> > 
> > Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@...at.org>
> > ---
> > 
> > v3:
> > - no changes
> > 
> > v2:
> > - Add Fixes and R-b tags
> > ---
> >   drivers/clk/loongson1/clk-loongson1c.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c
> > index 703f87622cf5f..a6f9f20fc8b99 100644
> > --- a/drivers/clk/loongson1/clk-loongson1c.c
> > +++ b/drivers/clk/loongson1/clk-loongson1c.c
> > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = {
> >   	[1] = { .val = 1, .div = 4 },
> >   	[2] = { .val = 2, .div = 3 },
> >   	[3] = { .val = 3, .div = 3 },
> > +	[4] = { /* sentinel */ },
> 
> Sorry for being nitpicky here, but we don't need the trailing comma,
> since this is the last entry.

Good point.

Thanks,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)