linux-kernel - Re: [PATCH v3 4/4] clk: clps711x: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Feb 2022 14:07:25 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Philippe Mathieu-Daudé <f4bug@...at.org>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Alexander Shiyan <shc_work@...l.ru>,
        Arnd Bergmann <arnd@...db.de>,
        Mike Turquette <mturquette@...aro.org>
Subject: Re: [PATCH v3 4/4] clk: clps711x: Terminate clk_div_table with
 sentinel element

On Sat, Feb 05, 2022 at 01:13:00PM +0100, Philippe Mathieu-Daudé wrote:
> On 5/2/22 01:52, Jonathan Neuschäfer wrote:
> > In order that the end of a clk_div_table can be detected, it must be
> > terminated with a sentinel element (.div = 0).
> > 
> > Fixes: 631c53478973d ("clk: Add CLPS711X clk driver")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > ---
> > 
> > v3:
> > - no changes
> > 
> > v2:
> > - Add Fixes tag
> > ---
> >   drivers/clk/clk-clps711x.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/clk/clk-clps711x.c b/drivers/clk/clk-clps711x.c
> > index a2c6486ef1708..d96d96c8752c7 100644
> > --- a/drivers/clk/clk-clps711x.c
> > +++ b/drivers/clk/clk-clps711x.c
> > @@ -28,11 +28,13 @@ static const struct clk_div_table spi_div_table[] = {
> >   	{ .val = 1, .div = 8, },
> >   	{ .val = 2, .div = 2, },
> >   	{ .val = 3, .div = 1, },
> > +	{}
> 
> Why not use the same style on all patches? Others developers looking
> at this code will directly grab this is a sentinel section, instead of
> wondering why this empty section is here.
> 
>         { /* sentinel */ }

I found the {} style sufficient.
But ok, I'll go with { /* sentinel */ } now.

> 
> Anyhow the patch logic is correct, so:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@...at.org>

Thanks!

Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)