linux-kernel - Re: [PATCH v2 4/5] dt-bindings: memory: lpddr3-timings: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57486a1b-8667-6f51-977f-16343572925e@gmail.com>
Date:   Sun, 6 Feb 2022 14:49:28 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: memory: lpddr3-timings: convert to
 dtschema

06.02.2022 14:20, Krzysztof Kozlowski пишет:
> On 05/02/2022 19:50, Dmitry Osipenko wrote:
>> 05.02.2022 15:00, Krzysztof Kozlowski пишет:
>>> +  reg:
>>> +    maxItems: 1
>>> +    description: |
>>> +      Maximum DDR clock frequency for the speed-bin, in Hz.
>>
>> Why max-freq is specified as a register? At minimum this is inconsistent
>> with the lpddr2 binding.
> 
> First of all, this is a conversion, so the bindings already specified
> max-freq that way.

The conversion part looks okay to me.

> Second, I don't know. I think this was some Lukasz's workaround for
> device node without unit address, but I don't see the reason now why it
> was needed.

I see now that actually there is one exynos5422-odroid-core.dtsi that
uses the 'reg' property.

> We could unify it with DDR2 by deprecating 'reg' and introducing
> 'max-freq', in separate commit. But you know, existing bindings are
> already there...

Will be great if you could add another patch to deprecate the 'reg'.
This will prevent returning to this topic in the future if somebody will
be adding lpddr3 timings, it also will make bindings to look consistent.

Thank you!