linux-kernel - Re: [PATCH] perf tools: apply correct label to user/kernel symbols in branch mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yf+2KfqJUdcYlSD3@kernel.org>
Date:   Sun, 6 Feb 2022 08:51:05 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     James Clark <james.clark@....com>
Cc:     German Gomez <german.gomez@....com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf tools: apply correct label to user/kernel symbols
 in branch mode

Em Wed, Jan 26, 2022 at 11:27:16AM +0000, James Clark escreveu:
> On 26/01/2022 10:59, German Gomez wrote:
> > @@ -928,7 +928,7 @@ static int hist_entry__sym_to_snprintf(struct hist_entry *he, char *bf,
> >  		struct addr_map_symbol *to = &he->branch_info->to;
> >  
> >  		return _hist_entry__sym_snprintf(&to->ms, to->al_addr,
> > -						 he->level, bf, size, width);
> > +						 to->al_level, bf, size, width);
> >  	}
> >  
> >  	return repsep_snprintf(bf, size, "%-*.*s", width, width, "N/A");
> > 
> 
> Looks good to me, I didn't see any other usages where it could be broken.
> 
> Reviewed-by: James Clark <james.clark@....com>


Thanks, applied.

- Arnaldo