linux-kernel - RE: [PATCH] openrisc: remove CONFIG_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3744dcbbf2874875b023548aacdd8b41@AcuMS.aculab.com>
Date:   Mon, 7 Feb 2022 17:14:43 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Christoph Hellwig' <hch@...radead.org>,
        Stafford Horne <shorne@...il.com>
CC:     LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        "Jonas Bonn" <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Randy Dunlap <rdunlap@...radead.org>,
        "openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>
Subject: RE: [PATCH] openrisc: remove CONFIG_SET_FS

From: Christoph Hellwig
> Sent: 07 February 2022 06:45
> 
> On Sun, Feb 06, 2022 at 10:36:47AM +0900, Stafford Horne wrote:
> > Remove the address space override API set_fs() used for User Mode Linux.
> 
> This ain't UML :)
> 
> > +	return size <= TASK_SIZE && addr <= (TASK_SIZE - size);
> 
> No need for the inner braces.

Since TASK_SIZE is actually an address wouldn't be better to
swap the condition around (in every architecture).

	return addr <= TASK_SIZE && size <= TASK_SIZE - addr;

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)