linux-kernel - Re: [PATCH] openrisc: remove CONFIG_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YgH/yC42RRbeJkiv@antec>
Date:   Tue, 8 Feb 2022 14:29:44 +0900
From:   Stafford Horne <shorne@...il.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     'Christoph Hellwig' <hch@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Randy Dunlap <rdunlap@...radead.org>,
        "openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>
Subject: Re: [PATCH] openrisc: remove CONFIG_SET_FS

On Mon, Feb 07, 2022 at 05:14:43PM +0000, David Laight wrote:
> From: Christoph Hellwig
> > Sent: 07 February 2022 06:45
> > 
> > On Sun, Feb 06, 2022 at 10:36:47AM +0900, Stafford Horne wrote:
> > > Remove the address space override API set_fs() used for User Mode Linux.
> > 
> > This ain't UML :)
> > 
> > > +	return size <= TASK_SIZE && addr <= (TASK_SIZE - size);
> > 
> > No need for the inner braces.
> 
> Since TASK_SIZE is actually an address wouldn't be better to
> swap the condition around (in every architecture).
> 
> 	return addr <= TASK_SIZE && size <= TASK_SIZE - addr;

Hi David,

I like that, it is more clear, I will update to that in v3.

-Stafford