linux-kernel - Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207204421.7f905aa5@jic23-huawei>
Date:   Mon, 7 Feb 2022 20:44:21 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Joe Perches <joe@...ches.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nuno Sá <nuno.sa@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code
 defined constants in messages

On Mon, 7 Feb 2022 19:21:25 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote:
> > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:  
> > > In a couple of messages the constants, which have their definitions,
> > > are hard coded into the message text. Unhardcode them.  
> > 
> > Found by inspection or tool?  
> 
> Does it matter? No, a side effect of the following patch.
> 
> ...
> 
> > > +		dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size,
> > > +			LTC2983_CUSTOM_STEINHART_SIZE);  
> > 
> > probably better using "%u" and not "%d"
> > 
> > and better with a \n termination too.  
> 
> I think it would be a separate change if we wish so. Let Jonathan to tell what
> to do here.
> 
Either way is fine by me.  I tend to be a little flexible of trivial fixes
in patches that are as simple as this one.

Thanks,

Jonathan