linux-kernel - Re: [PATCH] iio: adc: cpcap-adc: remove redundant assignment to variable cal_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 20:40:59 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: cpcap-adc: remove redundant assignment to
 variable cal_data_diff

On Mon,  7 Feb 2022 13:59:43 +0000
Colin Ian King <colin.i.king@...il.com> wrote:

> The variable cal_data_diff is being assigned a value that is never read,
> it is being re-assigned later on with a new value in both paths of an
> if statement. The assignment is redundant, so remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/cpcap-adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
> index 40e59f4c95bc..b6c4ef70484e 100644
> --- a/drivers/iio/adc/cpcap-adc.c
> +++ b/drivers/iio/adc/cpcap-adc.c
> @@ -474,7 +474,7 @@ static int cpcap_adc_calibrate_one(struct cpcap_adc *ddata,
>  	for (i = 0; i < CPCAP_ADC_MAX_RETRIES; i++) {
>  		calibration_data[0]  = 0;
>  		calibration_data[1]  = 0;
> -		cal_data_diff = 0;
> +
>  		cpcap_adc_setup_calibrate(ddata, channel);
>  		error = regmap_read(ddata->reg, calibration_register,
>  				    &calibration_data[0]);