linux-kernel - Re: [PATCH v4 12/12] arm64: dts: freescale: add initial support for verdin imx8m mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 17:49:55 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Alex Marginean <alexandru.marginean@....com>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        "Ariel D'Alessandro" <ariel.dalessandro@...labora.com>,
        Arnd Bergmann <arnd@...db.de>,
        Dong Aisheng <aisheng.dong@....com>,
        Frank Rowand <frowand.list@...il.com>,
        Jacky Bai <ping.bai@....com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Li Yang <leoyang.li@....com>,
        NXP Linux Team <linux-imx@....com>,
        Olof Johansson <olof@...om.net>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Tim Harvey <tharvey@...eworks.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 12/12] arm64: dts: freescale: add initial support for
 verdin imx8m mini

Hi Marcel,

On Fri, Feb 4, 2022 at 7:58 PM Marcel Ziswiler <marcel@...wiler.com> wrote:

> +/* On-module Wi-Fi */
> +&usdhc3 {
> +       bus-width = <4>;
> +       keep-power-in-suspend;
> +       non-removable;
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc3>, <&pinctrl_wifi_ctrl>;
> +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>, <&pinctrl_wifi_ctrl>;
> +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>, <&pinctrl_wifi_ctrl>;
> +       vmmc-supply = <&reg_wifi_en>;
> +       wifi-host;

wifi-host is not a valid property.

> +               /* Use the kernel configuration settings instead */
> +               /delete-node/ linux,cma;
> +
> +               rpmsg_reserved: rpmsg@...00000 {

I suppose this comes from the NXP vendor BSP and does not apply upstream.

> +/* Verdin CAN_1 (On-module) */
> +&ecspi3 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>,
> +                  <&gpio1 5 GPIO_ACTIVE_LOW>;
> +       spi-num-chipselects = <2>;

No need to specify "spi-num-chipselects". It is implicit by cs-gpios.

> +
> +&usbmisc1 {
> +       vbus-wakeup-supply = <&reg_vdd_3v3>;

Not a valid property.

> +};
> +
> +&usbmisc2 {
> +       vbus-wakeup-supply = <&reg_vdd_3v3>;

Ditto.

> +};
> +
> +/* Verdin USB_1 */
> +&usbotg1 {
> +       adp-disable;
> +       dr_mode = "otg";
> +       hnp-disable;
> +       over-current-active-low;
> +       picophy,dc-vol-level-adjust = <7>;

I guess you meant: samsung,picophy-dc-vol-level-adjust

> +       picophy,pre-emp-curr-control = <3>;

I guess you meant: samsung,picophy-pre-emp-curr-control

> +&usbotg2 {
> +       dr_mode = "host";
> +       over-current-active-low;
> +       picophy,dc-vol-level-adjust = <7>;
> +       picophy,pre-emp-curr-control = <3>;

Same here.