linux-kernel - Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24d02704-e590-63d0-4d8a-c76578249bea@collabora.com>
Date:   Tue, 8 Feb 2022 01:50:09 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        André Almeida <andrealmeid@...labora.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     usama.anjum@...labora.com, kernel@...labora.com,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH

On 2/7/22 11:40 PM, Shuah Khan wrote:
> On 1/19/22 3:33 AM, Muhammad Usama Anjum wrote:
>> If only futex selftest is compiled, uapi header files are copied to the
>> selftests/futex/functional directory. This copy isn't needed. Set the
>> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
>> path only. This removes extra copy of header file.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>> ---
>>   tools/testing/selftests/futex/functional/Makefile | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/futex/functional/Makefile
>> b/tools/testing/selftests/futex/functional/Makefile
>> index 5cc38de9d8ea..9a8c3700d773 100644
>> --- a/tools/testing/selftests/futex/functional/Makefile
>> +++ b/tools/testing/selftests/futex/functional/Makefile
>> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>>     top_srcdir = ../../../../..
>>   KSFT_KHDR_INSTALL := 1
>> +DEFAULT_INSTALL_HDR_PATH := 1
>>   include ../../lib.mk
>>     $(TEST_GEN_FILES): $(HEADERS)
>>
> 
> This will be a good cleanup. However, please make there is no dependencies
> in the futex test sub-dirs on being able to find the headers under futex
> 
I've tried the following variations. The build is fine.

cd tools/testing/selftests/futex/functional
make

cd tools/testing/selftests/futex/
make

make -C tools/testing/selftests/

> I vaguely remember leaving this in place for reason.
> 
This must have been fixed in previous changes made to the build system.

> thanks,
> -- Shuah
>