linux-kernel - Re: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd8ba6fc-b389-3e8e-2671-51656d3d8e5c@gmail.com>
Date:   Tue, 8 Feb 2022 00:50:15 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>, devicetree@...r.kernel.org,
        dmaengine@...r.kernel.org, jonathanh@...dia.com,
        kyarlagadda@...dia.com, ldewangan@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        p.zabel@...gutronix.de, rgumasta@...dia.com, robh+dt@...nel.org,
        thierry.reding@...il.com, vkoul@...nel.org
Cc:     Pavan Kunapuli <pkunapuli@...dia.com>
Subject: Re: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver

07.02.2022 18:01, Akhil R пишет:
> Adding GPC DMA controller driver for Tegra. The driver supports dma
> transfers between memory to memory, IO peripheral to memory and
> memory to IO peripheral.
> 
> Co-developed-by: Pavan Kunapuli <pkunapuli@...dia.com>
> Signed-off-by: Pavan Kunapuli <pkunapuli@...dia.com>
> Co-developed-by: Rajesh Gumasta <rgumasta@...dia.com>
> Signed-off-by: Rajesh Gumasta <rgumasta@...dia.com>
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> Reviewed-by: Jon Hunter <jonathanh@...dia.com>
> ---
>  drivers/dma/Kconfig            |   11 +
>  drivers/dma/Makefile           |    1 +
>  drivers/dma/tegra186-gpc-dma.c | 1505 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1517 insertions(+)
>  create mode 100644 drivers/dma/tegra186-gpc-dma.c

Looks okay to me. Thank you for the effort!

Coding style isn't ideal:

 - inconsistent alignment of the code
 - unnecessary whitespaces and parens
 - inconsistent variables type signes
 - all abbreviation should be capitalized in comments and commit msg

but this is not critical and could be improved later on.

Reviewed-by: Dmitry Osipenko <digetx@...il.com>