linux-kernel - RE: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 17:22:12 +0000
From:   Akhil R <akhilrajeev@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Rajesh Gumasta <rgumasta@...dia.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>
CC:     Pavan Kunapuli <pkunapuli@...dia.com>
Subject: RE: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver

> 07.02.2022 18:01, Akhil R пишет:
> > Adding GPC DMA controller driver for Tegra. The driver supports dma
> > transfers between memory to memory, IO peripheral to memory and
> > memory to IO peripheral.
> >
> > Co-developed-by: Pavan Kunapuli <pkunapuli@...dia.com>
> > Signed-off-by: Pavan Kunapuli <pkunapuli@...dia.com>
> > Co-developed-by: Rajesh Gumasta <rgumasta@...dia.com>
> > Signed-off-by: Rajesh Gumasta <rgumasta@...dia.com>
> > Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> > Reviewed-by: Jon Hunter <jonathanh@...dia.com>
> > ---
> >  drivers/dma/Kconfig            |   11 +
> >  drivers/dma/Makefile           |    1 +
> >  drivers/dma/tegra186-gpc-dma.c | 1505
> ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1517 insertions(+)
> >  create mode 100644 drivers/dma/tegra186-gpc-dma.c
> 
> Looks okay to me. Thank you for the effort!
> 
> Coding style isn't ideal:
> 
>  - inconsistent alignment of the code
>  - unnecessary whitespaces and parens
>  - inconsistent variables type signes
>  - all abbreviation should be capitalized in comments and commit msg
> 
> but this is not critical and could be improved later on.
> 
> Reviewed-by: Dmitry Osipenko <digetx@...il.com>

Thanks for the review.

Regards,
Akhil