linux-kernel - Re: [PATCH] memory: mtk-smi: Enable sleep ctrl safety function for MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Feb 2022 09:59:13 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Macpaul Lin <macpaul.lin@...iatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, yong.wu@...iatek.com
Cc:     matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] memory: mtk-smi: Enable sleep ctrl safety function for
 MT8195

On 07/02/2022 04:12, Macpaul Lin wrote:
> On 2/4/22 8:55 PM, AngeloGioacchino Del Regno wrote:
>> Enable the sleep ctrl function to wait until all the queued commands
>> are executed before suspending the LARBs, like done for MT8186.
>> 
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   drivers/memory/mtk-smi.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
>> index c22acd3ddd10..86a3d34f418e 100644
>> --- a/drivers/memory/mtk-smi.c
>> +++ b/drivers/memory/mtk-smi.c
>> @@ -351,7 +351,8 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = {
>>   
>>   static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = {
>>   .config_port                = mtk_smi_larb_config_port_gen2_general,
>> -.flags_general            = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG,
>> +.flags_general            = MTK_SMI_FLAG_THRT_UPDATE | MTK_SMI_FLAG_SW_FLAG |
>> +      MTK_SMI_FLAG_SLEEP_CTL,
>>   .ostd            = mtk_smi_larb_mt8195_ostd,
>>   };
>>   
>> 
> 
> Reviewed-by: Macpaul Lin <macpaul.lin@...iatek.com>

Thanks for the review, appreciated!


> ************* MEDIATEK Confidentiality Notice
>  ********************
> The information contained in this e-mail message (including any 
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be 
> conveyed only to the designated recipient(s). Any use, dissemination, 
> distribution, printing, retaining or copying of this e-mail (including its 
> attachments) by unintended recipient(s) is strictly prohibited and may 
> be unlawful. If you are not an intended recipient of this e-mail, or believe
>  
> that you have received this e-mail in error, please notify the sender 
> immediately (by replying to this e-mail), delete any and all copies of 
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!

Please work on your email setup, so we won't see such stuff. I know it
is autogenerated by company systems, yet still it should not be put in
public discussion.


Best regards,
Krzysztof