linux-kernel - Re: [v1 1/2] dt-bindings: power: Add MT8186 power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <618ca2903de8fe3b1f68c450273af7a170de2675.camel@mediatek.com>
Date:   Mon, 7 Feb 2022 16:53:42 +0800
From:   Chun-Jie Chen <chun-jie.chen@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh@...nel.org>
CC:     Enric Balletbo Serra <eballetbo@...il.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <srv_heupstream@...iatek.com>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [v1 1/2] dt-bindings: power: Add MT8186 power domains

On Fri, 2022-01-14 at 13:49 +0100, Matthias Brugger wrote:
> 
> On 12/01/2022 03:05, Rob Herring wrote:
> > On Sat, Jan 08, 2022 at 09:19:52PM +0800, Chun-Jie Chen wrote:
> > > Add power domains dt-bindings for MT8186.
> > > 
> > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@...iatek.com>
> > > ---
> > >   .../power/mediatek,power-controller.yaml      |  1 +
> > >   include/dt-bindings/power/mt8186-power.h      | 32
> > > +++++++++++++++++++
> > >   2 files changed, 33 insertions(+)
> > >   create mode 100644 include/dt-bindings/power/mt8186-power.h
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > b/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > index d6ebd77d28a7..135c6f722091 100644
> > > --- a/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > +++ b/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > @@ -26,6 +26,7 @@ properties:
> > >         - mediatek,mt8167-power-controller
> > >         - mediatek,mt8173-power-controller
> > >         - mediatek,mt8183-power-controller
> > > +      - mediatek,mt8186-power-controller
> > >         - mediatek,mt8192-power-controller
> > >         - mediatek,mt8195-power-controller
> > >   
> > > diff --git a/include/dt-bindings/power/mt8186-power.h
> > > b/include/dt-bindings/power/mt8186-power.h
> > > new file mode 100644
> > > index 000000000000..ca8ea2d24801
> > > --- /dev/null
> > > +++ b/include/dt-bindings/power/mt8186-power.h
> > > @@ -0,0 +1,32 @@
> > > +/* SPDX-License-Identifier: GPL-2.0-only */
> > 
> > Dual license please.
> > 
> 
> Other then that series looks good.
> 
> Regards,
> Matthias
> 

Ok, I will update license in next patch.

Thanks!
Best Regards,
Chun-Jie

> > > +/*
> > > + * Copyright (c) 2022 MediaTek Inc.
> > > + * Author: Chun-Jie Chen <chun-jie.chen@...iatek.com>
> > > + */
> > > +
> > > +#ifndef _DT_BINDINGS_POWER_MT8186_POWER_H
> > > +#define _DT_BINDINGS_POWER_MT8186_POWER_H
> > > +
> > > +#define MT8186_POWER_DOMAIN_MFG0			0
> > > +#define MT8186_POWER_DOMAIN_MFG1			1
> > > +#define MT8186_POWER_DOMAIN_MFG2			2
> > > +#define MT8186_POWER_DOMAIN_MFG3			3
> > > +#define MT8186_POWER_DOMAIN_SSUSB			4
> > > +#define MT8186_POWER_DOMAIN_SSUSB_P1			5
> > > +#define MT8186_POWER_DOMAIN_DIS				6
> > > +#define MT8186_POWER_DOMAIN_IMG				7
> > > +#define MT8186_POWER_DOMAIN_IMG2			8
> > > +#define MT8186_POWER_DOMAIN_IPE				9
> > > +#define MT8186_POWER_DOMAIN_CAM				10
> > > +#define MT8186_POWER_DOMAIN_CAM_RAWA			11
> > > +#define MT8186_POWER_DOMAIN_CAM_RAWB			12
> > > +#define MT8186_POWER_DOMAIN_VENC			13
> > > +#define MT8186_POWER_DOMAIN_VDEC			14
> > > +#define MT8186_POWER_DOMAIN_WPE				15
> > > +#define MT8186_POWER_DOMAIN_CONN_ON			16
> > > +#define MT8186_POWER_DOMAIN_CSIRX_TOP			17
> > > +#define MT8186_POWER_DOMAIN_ADSP_AO			18
> > > +#define MT8186_POWER_DOMAIN_ADSP_INFRA			19
> > > +#define MT8186_POWER_DOMAIN_ADSP_TOP			20
> > > +
> > > +#endif /* _DT_BINDINGS_POWER_MT8186_POWER_H */
> > > -- 
> > > 2.18.0
> > > 
> > >