linux-kernel - Re: [PATCH v4 6/9] i2c: piix4: Add EFCH MMIO support to region request and release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 16:49:38 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Terry Bowman <terry.bowman@....com>
Cc:     <linux@...ck-us.net>, <linux-watchdog@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <wsa@...nel.org>,
        <andy.shevchenko@...il.com>, <rafael.j.wysocki@...el.com>,
        <linux-kernel@...r.kernel.org>, <wim@...ux-watchdog.org>,
        <rrichter@....com>, <thomas.lendacky@....com>,
        <sudheesh.mavila@....com>, <Nehal-bakulchandra.Shah@....com>,
        <Basavaraj.Natikar@....com>, <Shyam-sundar.S-k@....com>,
        <Mario.Limonciello@....com>
Subject: Re: [PATCH v4 6/9] i2c: piix4: Add EFCH MMIO support to region
 request and release

Hi Terry,

On Sun, 30 Jan 2022 12:41:27 -0600, Terry Bowman wrote:
> EFCH cd6h/cd7h port I/O may no longer be available on later AMD
> processors and it is recommended to use MMIO instead. Update the
> request and release functions to support MMIO.
> 
> MMIO request/release and mmapping require details during cleanup.
> Add a MMIO configuration structure containing resource and vaddress
> details for mapping the region, accessing the region, and releasing
> the region.
> 
> Signed-off-by: Terry Bowman <terry.bowman@....com>
> ---
>  drivers/i2c/busses/i2c-piix4.c | 61 ++++++++++++++++++++++++++++++----
>  1 file changed, 55 insertions(+), 6 deletions(-)
> (...)
> @@ -880,6 +928,7 @@ static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba,
>  		return -ENOMEM;
>  	}
>  
> +	adapdata->mmio_cfg.use_mmio = 0;

Useless initialization, as the adapdata structure has just been zalloc'd.

>  	adapdata->smba = smba;
>  	adapdata->sb800_main = sb800_main;
>  	adapdata->port = port << piix4_port_shift_sb800;


-- 
Jean Delvare
SUSE L3 Support