linux-kernel - Re: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the flash node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 14:05:51 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>
Cc:     <vigneshr@...com>, <richard@....at>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <git@...inx.com>
Subject: Re: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the
 flash node

Hi Amit,

amit.kumar-mahapatra@...inx.com wrote on Tue, 8 Feb 2022 18:27:38 +0530:

> In devicetree the flash information is embedded within nand chip node,
> so during nand chip initialization the nand chip node should be passed
> to nand_set_flash_node() api, instead of nand controller node.
> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@...inx.com>

Can you please add Fixes tag?

> ---
> BRANCH: nand/next
> ---
>  drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> index 8a91e069ee2e..3c6f6aff649f 100644
> --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
> +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> @@ -1062,7 +1062,7 @@ static int pl35x_nand_chip_init(struct pl35x_nandc *nfc,
>  	chip->controller = &nfc->controller;
>  	mtd = nand_to_mtd(chip);
>  	mtd->dev.parent = nfc->dev;
> -	nand_set_flash_node(chip, nfc->dev->of_node);
> +	nand_set_flash_node(chip, np);
>  	if (!mtd->name) {
>  		mtd->name = devm_kasprintf(nfc->dev, GFP_KERNEL,
>  					   "%s", PL35X_NANDC_DRIVER_NAME);

yup, that was wrong.

Thanks,
Miquèl