lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Feb 2022 13:39:32 +0100 From: Hans Verkuil <hverkuil-cisco@...all.nl> To: Dikshita Agarwal <quic_dikshita@...cinc.com> Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, vgarodia@...eaurora.org Subject: Re: [PATCH] Add check for READ ONLY flag On 2/4/22 07:47, Dikshita Agarwal wrote: > Add a check for V4L2_CTRL_FLAG_READ_ONLY to avoid request > testing for such controls. Missing Signed-off-by! Regards, Hans > --- > utils/v4l2-compliance/v4l2-test-buffers.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp b/utils/v4l2-compliance/v4l2-test-buffers.cpp > index fa8c37c..b8de7af 100644 > --- a/utils/v4l2-compliance/v4l2-test-buffers.cpp > +++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp > @@ -2032,7 +2032,8 @@ int testRequests(struct node *node, bool test_streaming) > if (qctrl.type != V4L2_CTRL_TYPE_INTEGER && > qctrl.type != V4L2_CTRL_TYPE_BOOLEAN) > continue; > - if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY) > + if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY || > + qctrl.flags & V4L2_CTRL_FLAG_READ_ONLY) > continue; > if (is_vivid && V4L2_CTRL_ID2WHICH(qctrl.id) == V4L2_CTRL_CLASS_VIVID) > continue;
Powered by blists - more mailing lists