Message-ID: <YgJyiiLqLu44MWF1@sirena.org.uk>
Date:   Tue, 8 Feb 2022 13:39:22 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Marek Behún <kabel@...nel.org>,
        Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Markuss Broks <markuss.broks@...il.com>,
        Emma Anholt <emma@...olt.net>,
        David Lechner <david@...hnology.com>,
        Kamlesh Gurudasani <kamlesh.gurudasani@...il.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Dan Robertson <dan@...obertson.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Pavel Machek <pavel@....cz>,
        Yasunari Takiguchi <Yasunari.Takiguchi@...y.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Charles-Antoine Couret <charles-antoine.couret@...vision.fr>,
        Antti Palosaari <crope@....fi>,
        Lee Jones <lee.jones@...aro.org>,
        Support Opensource <support.opensource@...semi.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Eric Piel <eric.piel@...mplin-utc.net>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Thomas Kopp <thomas.kopp@...rochip.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Łukasz Stelmach <l.stelmach@...sung.com>,
        Alexander Aring <alex.aring@...il.com>,
        Stefan Schmidt <stefan@...enfreihafen.org>,
        Harry Morris <h.morris@...coda.com>,
        Varka Bhadram <varkabhadram@...il.com>,
        Xue Liu <liuxuenetmail@...il.com>, Alan Ott <alan@...nal11.us>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>,
        Ajay Singh <ajay.kathat@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Solomon Peachy <pizza@...ftnet.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Mark Greer <mgreer@...malcreek.com>,
        Benson Leung <bleung@...omium.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Jérôme Pouiller <jerome.pouiller@...abs.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Helge Deller <deller@....de>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Lucas Tanure <tanureal@...nsource.cirrus.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Daniel Mack <daniel@...que.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Maxime Ripard <mripard@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        Gwendal Grignou <gwendal@...omium.org>,
        Cai Huoqing <caihuoqing@...du.com>,
        Minghao Chi <chi.minghao@....com.cn>,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Ronald Tschalär <ronald@...ovation.ch>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
        Jon Hunter <jonathanh@...dia.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Heiko Schocher <hs@...x.de>,
        Fabio Estevam <festevam@...il.com>,
        Colin Ian King <colin.king@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Matt Kline <matt@...bashing.io>,
        Torin Cooper-Bennun <torin@...iluxsystems.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Stefan Mätje <stefan.maetje@....eu>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Nanyong Sun <sunnanyong@...wei.com>,
        Yang Shen <shenyang39@...wei.com>,
        dingsenjie <dingsenjie@...ong.com>,
        Aditya Srivastava <yashsri421@...il.com>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michael Walle <michael@...le.cc>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        wengjianfeng <wengjianfeng@...ong.com>,
        Sidong Yang <realwakka@...il.com>,
        Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>,
        Zhang Qilong <zhangqilong3@...wei.com>,
        Will Deacon <will@...nel.org>,
        Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>,
        Davidlohr Bueso <dbueso@...e.de>, Claudius Heine <ch@...x.de>,
        Jiri Prchal <jiri.prchal@...ignal.cz>,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-hwmon@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-input@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
        patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-wpan@...r.kernel.org,
        linux-wireless@...r.kernel.org, libertas-dev@...ts.infradead.org,
        platform-driver-x86@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-serial@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH 5/5] spi: make remove callback a void function

On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-König wrote:
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
> 
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.

I was going to apply this but it needs rebasing against current code
unfortunately.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists