linux-kernel - Re: [PATCH v2 1/3] dt-bindings: crypto: Convert Atmel AES to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Feb 2022 14:40:07 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <krzysztof.kozlowski@...onical.com>, <herbert@...dor.apana.org.au>
CC:     <Nicolas.Ferre@...rochip.com>, <Claudiu.Beznea@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <Kavyasree.Kotagiri@...rochip.com>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: Convert Atmel AES to yaml

On 2/8/22 13:58, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 08/02/2022 11:49, Tudor Ambarus wrote:
>> Convert Atmel AES documentation to yaml format. With the conversion the
>> clock and clock-names properties are made mandatory. The driver returns
>> -EINVAL if "aes_clk" is not found, reflect that in the bindings and make
>> the clock and clock-names properties mandatory. Update the example to
>> better describe how one should define the dt node.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
>> ---
>>  .../crypto/atmel,at91sam9g46-aes.yaml         | 65 +++++++++++++++++++
>>  .../bindings/crypto/atmel-crypto.txt          | 20 ------
>>  2 files changed, 65 insertions(+), 20 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
>>
> 
> I understand that you keep the license GPL-2.0 (not recommended mix)
> because of example coming from previous bindings or from DTS (both GPL-2.0)?
> 

The previous bindings did not have a license specified. We have DTS files with
these nodes that are either (GPL-2.0+ OR MIT) or GPL-2.0-or-later. The drivers
are GPL-2.0. I thought to follow the drivers. I see the example in [1] uses
(GPL-2.0-only OR BSD-2-Clause). I see the crypto bindings that are converted
to yaml are either (GPL-2.0-only OR BSD-2-Clause) or GPL-2.0-only. Is there
another guideline that I miss?

Thanks,
ta

[1] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html