linux-kernel - Re: [PATCH] spi: spi-zynq-qspi: Fix a NULL pointer dereference in zynq_qspi_exec_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164433288249.2965024.5625458005559637267.b4-ty@kernel.org>
Date:   Tue, 08 Feb 2022 15:08:02 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Zhou Qingyang <zhou1615@....edu>
Cc:     Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org,
        Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>,
        linux-spi@...r.kernel.org, kjlu@....edu,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] spi: spi-zynq-qspi: Fix a NULL pointer dereference in zynq_qspi_exec_mem_op()

On Wed, 1 Dec 2021 01:22:53 +0800, Zhou Qingyang wrote:
> In zynq_qspi_exec_mem_op(), kzalloc() is directly used in memset(),
> which could lead to a NULL pointer dereference on failure of
> kzalloc().
> 
> Fix this bug by adding a check of tmpbuf.
> 
> This bug was found by a static analyzer. The analysis employs
> differential checking to identify inconsistent security operations
> (e.g., checks or kfrees) between two code paths and confirms that the
> inconsistent operations are not recovered in the current function or
> the callers, so they constitute bugs.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-linus

Thanks!

[1/1] spi: spi-zynq-qspi: Fix a NULL pointer dereference in zynq_qspi_exec_mem_op()
      commit: ab3824427b848da10e9fe2727f035bbeecae6ff4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark