linux-kernel - Re: [PATCH v4 4/9] i2c: piix4: Move SMBus controller base address detect into function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220208160930.4140ed73@endymion.delvare>
Date:   Tue, 8 Feb 2022 16:09:30 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Terry Bowman <terry.bowman@....com>
Cc:     <linux@...ck-us.net>, <linux-watchdog@...r.kernel.org>,
        <linux-i2c@...r.kernel.org>, <wsa@...nel.org>,
        <andy.shevchenko@...il.com>, <rafael.j.wysocki@...el.com>,
        <linux-kernel@...r.kernel.org>, <wim@...ux-watchdog.org>,
        <rrichter@....com>, <thomas.lendacky@....com>,
        <sudheesh.mavila@....com>, <Nehal-bakulchandra.Shah@....com>,
        <Basavaraj.Natikar@....com>, <Shyam-sundar.S-k@....com>,
        <Mario.Limonciello@....com>
Subject: Re: [PATCH v4 4/9] i2c: piix4: Move SMBus controller base address
 detect into function

On Sun, 30 Jan 2022 12:41:25 -0600, Terry Bowman wrote:
>  static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
>  			     const struct pci_device_id *id, u8 aux)
>  {
> -	unsigned short piix4_smba;
> -	u8 smba_en_lo, smba_en_hi, smb_en, smb_en_status, port_sel;
> +	u8 smb_en, smb_en_status, port_sel;
>  	u8 i2ccfg, i2ccfg_offset = 0x10;
> +	unsigned short piix4_smba;
>  	int retval;
>  
>  	/* SB800 and later SMBus does not support forcing address */

I suggest not moving variables around unless there's a compelling to do
that. Else you make your patches larger (and slightly harder to
review), plus it increases the risks of context conflicts when
backporting other changes.

Thanks,
-- 
Jean Delvare
SUSE L3 Support