linux-kernel - Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Feb 2022 17:12:20 +0200
From:   <alexandru.tachici@...log.com>
To:     <o.rempel@...gutronix.de>
CC:     <alexandru.tachici@...log.com>, <andrew@...n.ch>,
        <davem@...emloft.net>, <devicetree@...r.kernel.org>,
        <hkallweit1@...il.com>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux@...linux.org.uk>,
        <netdev@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45

> On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > > +		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > > +		if (ret < 0)
> > > +			return ret;
> > > +
> > > +		if (ret & MDIO_PMA_EXTABLE_BT1)
> > 
> > 
> > This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> > for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> > is expected to change is it? So i wounder if it should be read once
> > and stored away?
> 
> What is the state of this patches? Will you be able to make requested
> changes and send new version?

I will come back with a V5 where I will add the requested changes.

Regards,
Alexandru