linux-kernel - Re: [PATCH] spi: initialize ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgPs8U85ZFbDWYlx@sirena.org.uk>
Date:   Wed, 9 Feb 2022 16:33:53 +0000
From:   Mark Brown <broonie@...nel.org>
To:     trix@...hat.com
Cc:     lhjeff911@...il.com, nathan@...nel.org, ndesaulniers@...gle.com,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] spi: initialize ret variable

On Wed, Feb 09, 2022 at 08:30:29AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang build fails with
> spi-sunplus-sp7021.c:405:2: error: variable 'ret' is used
>   uninitialized whenever switch default is taken
>         default:
>         ^~~~~~~
> 
> Restore initializing ret.

Are you sure this is a good fix and that the compiler hasn't instead
identifed that we should be returning an error in the default case?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)