linux-kernel - Re: [PATCH v14 03/11] iio: afe: rescale: add offset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgPtZpYGWvjX5c4U@shaak>
Date:   Wed, 9 Feb 2022 11:35:50 -0500
From:   Liam Beguin <liambeguin@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Peter Rosin <peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v14 03/11] iio: afe: rescale: add offset support

Hi Andy,

On Tue, Feb 08, 2022 at 03:42:22PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 8, 2022 at 4:04 AM Liam Beguin <liambeguin@...il.com> wrote:
> >
> > This is a preparatory change required for the addition of temperature
> > sensing front ends.
> 
> ...
> 
> > +               if (iio_channel_has_info(rescale->source->channel,
> > +                                        IIO_CHAN_INFO_OFFSET)) {
> > +                       ret = iio_read_channel_offset(rescale->source,
> > +                                                     &schan_off, NULL);
> 
> > +                       if (ret != IIO_VAL_INT)
> > +                               return ret < 0 ? ret : -EOPNOTSUPP;
> 
> Wonder if this actually should be
> 
>    if (ret < 0)
>        return ret;
>    if (ret != ...)
>        return -EOP...;

Unless someone has a stong objection, I'd rather keep it as is.

Cheers,
Liam

> > +               }
> 
> -- 
> With Best Regards,
> Andy Shevchenko