[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8016293e-5100-1cda-89ea-8a9b5491132a@quantatw.com>
Date: Thu, 10 Feb 2022 00:46:27 +0800
From: POTIN LAI <potin.lai@...ntatw.com>
To: Rob Herring <robh+dt@...nel.org>
Cc: Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
Patrick Williams <patrick@...cx.xyz>,
Allen Wang <Allen_Wang@...ntatw.com>,
devicetree@...r.kernel.org,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] arch: arm: dts: update bletchley dts
Rob Herring 於 9/02/2022 11:33 pm 寫道:
> On Wed, Feb 9, 2022 at 4:04 AM Potin Lai <potin.lai@...ntatw.com> wrote:
>> updates:
>> * seperate leds into multiple groups
>> * switch sled numbering to 1-based
>> * disable inchip rtc
>> * add flash1 in fmc
>> * switch spi2 pnor using spi-gpio
>> * update gpio-line-names
>> * add interrupt pin for each sledx_ioexp
>> * enable mdio3
>> * update ADM1278 shunt resistor (300 micro Ohm)
>> * add INA230 for each sled
> Please read documentation on writing commit messages. Answer why you
> are making the change, not what you are changing.
>
> Each bullet should probably be a separate commit. The question to
> answer is are there compatibility issues (what happens with old DT and
> new kernel and vice-versa)?
>
> Rob
Thank you very much for advising, will update this patch in new patch series.
Potin
Powered by blists - more mailing lists