[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqLM552FjvjdECq56kYsx9+mPuyvpUNibtuH--pgyF4pDQ@mail.gmail.com>
Date: Wed, 9 Feb 2022 09:33:44 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Potin Lai <potin.lai@...ntatw.com>
Cc: Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
Patrick Williams <patrick@...cx.xyz>,
Allen Wang <Allen_Wang@...ntatw.com>,
devicetree@...r.kernel.org,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] arch: arm: dts: update bletchley dts
On Wed, Feb 9, 2022 at 4:04 AM Potin Lai <potin.lai@...ntatw.com> wrote:
>
> updates:
> * seperate leds into multiple groups
> * switch sled numbering to 1-based
> * disable inchip rtc
> * add flash1 in fmc
> * switch spi2 pnor using spi-gpio
> * update gpio-line-names
> * add interrupt pin for each sledx_ioexp
> * enable mdio3
> * update ADM1278 shunt resistor (300 micro Ohm)
> * add INA230 for each sled
Please read documentation on writing commit messages. Answer why you
are making the change, not what you are changing.
Each bullet should probably be a separate commit. The question to
answer is are there compatibility issues (what happens with old DT and
new kernel and vice-versa)?
Rob
Powered by blists - more mailing lists