linux-kernel - Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h35ksqzx7.wl-tiwai@suse.de>
Date:   Wed, 09 Feb 2022 08:09:24 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Mohan Kumar <mkumard@...dia.com>
Cc:     <broonie@...nel.org>, <lgirdwood@...il.com>, <robh+dt@...nel.org>,
        <thierry.reding@...il.com>, <tiwai@...e.com>,
        <jonathanh@...dia.com>, <spujar@...dia.com>,
        <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication

On Wed, 09 Feb 2022 05:23:23 +0100,
Mohan Kumar wrote:
> 
> --- a/include/sound/hda_codec.h
> +++ b/include/sound/hda_codec.h
> @@ -240,6 +240,10 @@ struct hda_codec {
>  	unsigned int single_adc_amp:1; /* adc in-amp takes no index
>  					* (e.g. CX20549 codec)
>  					*/
> +	unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger
> +					     * control flag
> +					     * (e.g. Nvidia codecs)
> +					     */

This flag is specific to (Nvidia) HDMI codec and referred only from
patch_hdmi.c, right?  If so, the flag would be better put locally to
struct hdmi_spec instead of a global hda_codec.


thanks,

Takashi