linux-kernel - RE: [PATCH] can: xilinx_can: Add check for NAPI Poll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR02MB53867DD5740FAA93CB5BC3B4AF2E9@DM6PR02MB5386.namprd02.prod.outlook.com>
Date:   Wed, 9 Feb 2022 08:40:48 +0000
From:   Srinivas Neeli <sneeli@...inx.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
CC:     "wg@...ndegger.com" <wg@...ndegger.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Appana Durga Kedareswara Rao <appanad@...inx.com>,
        Srinivas Goud <sgoud@...inx.com>, git <git@...inx.com>
Subject: RE: [PATCH] can: xilinx_can: Add check for NAPI Poll function

Hi Marc,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: Wednesday, February 9, 2022 2:02 PM
> To: Srinivas Neeli <sneeli@...inx.com>
> Cc: wg@...ndegger.com; davem@...emloft.net; kuba@...nel.org; Michal
> Simek <michals@...inx.com>; linux-can@...r.kernel.org;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Appana Durga Kedareswara Rao
> <appanad@...inx.com>; Srinivas Goud <sgoud@...inx.com>; git
> <git@...inx.com>
> Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function
> 
> On 09.02.2022 08:29:55, Srinivas Neeli wrote:
> > > On 08.02.2022 21:50:53, Srinivas Neeli wrote:
> > > > Add check for NAPI poll function to avoid enabling interrupts with
> > > > out completing the NAPI call.
> > >
> > > Thanks for the patch. Does this fix a bug? If so, please add a Fixes:
> > > tag that lists the patch that introduced that bug.
> >
> > It is not a bug. I am adding additional safety check( Validating the
> > return value of "napi_complete_done" call).
> 
> Thanks for your feedback. Should this go into can or can-next?

If possible please apply on both branches.

> 
> regards,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |