linux-kernel - Re: [PATCH] i2c: bcm2835: Fix the error handling in 'bcm2835_i2c_probe()'

Open Source and information security mailing list archives

Message-ID: <7260c0a6-6771-6dd6-2c1d-43c1b70d2699@wanadoo.fr>
Date:   Thu, 10 Feb 2022 20:50:43 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Wolfram Sang <wsa@...nel.org>, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com, nsaenz@...nel.org,
        krzk@...nel.org, stefan.wahren@...e.com, nh6z@...z.net,
        eric@...olt.net, linux-i2c@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] i2c: bcm2835: Fix the error handling in
 'bcm2835_i2c_probe()'

Le 07/02/2022 à 15:47, Wolfram Sang a écrit :
> On Fri, Aug 20, 2021 at 08:43:33PM +0200, Christophe JAILLET wrote:
>> Some resource should be released if an error occurs in
>> 'bcm2835_i2c_probe()'.
>> Add an error handling path and the needed 'clk_disable_unprepare()' and
>> 'clk_rate_exclusive_put()' calls.
>>
>> While at it, rework the bottom of the function to use this newly added
>> error handling path and have an explicit and more standard "return 0;" at
>> the end of the normal path.
>>
>> Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Sadly, noone tested it but I think it is good to avoid the resource
> leaks. So, rebased and applied to for-next, thanks! Please kindly check
> if I rebased correctly the irq error case (once I pushed out).
> 

LGTM.

CJ
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives