linux-kernel - Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgWNE05eVK+LijL/@kunai>
Date:   Thu, 10 Feb 2022 23:09:23 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Jan Dabros <jsd@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, hdegoede@...hat.com,
        rrangel@...omium.org, mw@...ihalf.com, jaz@...ihalf.com,
        upstream@...ihalf.com, thomas.lendacky@....com,
        alexander.deucher@....com, Nimesh.Easow@....com,
        mario.limonciello@....com
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
> Implement an I2C controller sharing mechanism between the host (kernel)
> and PSP co-processor on some platforms equipped with AMD Cezanne SoC.
> 
> On these platforms we need to implement "software" i2c arbitration.
> Default arbitration owner is PSP and kernel asks for acquire as well
> as inform about release of the i2c bus via mailbox mechanism.
> 
>             +---------+
>  <- ACQUIRE |         |
>   +---------|   CPU   |\
>   |         |         | \      +----------+  SDA

Applied to for-next, thanks! I fixed the following checkpatch warnings:

CHECK: Please don't use multiple blank lines
#232: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:92:
+
+

WARNING: braces {} are not necessary for single statement blocks
#361: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:221:
+	if (ret) {
+		goto cleanup;
+	}

Please also use checkpatch next time.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)