linux-kernel - Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtMz3OyYXeyrpcSUpHZCR4tqroKWd09gYsjsU2W_idt8udMbQ@mail.gmail.com>
Date:   Fri, 11 Feb 2022 00:05:08 +0100
From:   Jan Dąbroś <jsd@...ihalf.com>
To:     Wolfram Sang <wsa@...nel.org>, Jan Dabros <jsd@...ihalf.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Raul E Rangel <rrangel@...omium.org>,
        Marcin Wojtas <mw@...ihalf.com>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>, upstream@...ihalf.com,
        Tom Lendacky <thomas.lendacky@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        "Easow, Nimesh" <Nimesh.Easow@....com>,
        "Limonciello, Mario" <mario.limonciello@....com>
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

czw., 10 lut 2022 o 23:09 Wolfram Sang <wsa@...nel.org> napisał(a):
>
> On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
> > Implement an I2C controller sharing mechanism between the host (kernel)
> > and PSP co-processor on some platforms equipped with AMD Cezanne SoC.
> >
> > On these platforms we need to implement "software" i2c arbitration.
> > Default arbitration owner is PSP and kernel asks for acquire as well
> > as inform about release of the i2c bus via mailbox mechanism.
> >
> >             +---------+
> >  <- ACQUIRE |         |
> >   +---------|   CPU   |\
> >   |         |         | \      +----------+  SDA
>
> Applied to for-next, thanks!

Thanks a lot!

> I fixed the following checkpatch warnings:
>
> CHECK: Please don't use multiple blank lines
> #232: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:92:
> +
> +
>
> WARNING: braces {} are not necessary for single statement blocks
> #361: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:221:
> +       if (ret) {
> +               goto cleanup;
> +       }
>
> Please also use checkpatch next time.

Ooops, sorry for this. Actually I used checkpatch till v3, but forgot
to run this on v4 where this change was introduced, my bad. Will
improve going forward :)

Best Regards,
Jan