linux-kernel - Re: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Feb 2022 14:33:57 +0100
From:   Michael Walle <michael@...le.cc>
To:     Kavyasree.Kotagiri@...rochip.com
Cc:     Tudor.Ambarus@...rochip.com, Manohar.Puri@...rochip.com,
        Nicolas.Ferre@...rochip.com, UNGLinuxDriver@...rochip.com,
        alexandre.belloni@...tlin.com, arnd@...db.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, olof@...om.net, robh+dt@...nel.org,
        soc@...nel.org
Subject: Re: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291

Am 2022-02-10 14:02, schrieb Kavyasree.Kotagiri@...rochip.com:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the
>> content is safe
>> 
>> Hi,
>> 
>> >  arch/arm/boot/dts/Makefile            |   2 +
>> >  arch/arm/boot/dts/lan966x.dtsi        | 237 ++++++++++++++++++++++++++
>> >  arch/arm/boot/dts/lan966x_pcb8291.dts |  61 +++++++
>> 
>> Please rename this to lan966x-pcb8921.dts. All (most?) of the device
>> tree files use the dash as a seperator between the SoC and the board.
>> 
> Ok, I will change in my v6.
> Please have a look at my v5 patch where I already addressed all the
> node naming changes.

My comments besides the renaming still apply.

-michael