linux-kernel - Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com>
Date:   Mon, 14 Feb 2022 13:57:31 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Peter Gonda <pgonda@...gle.com>, kvm@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Marc Orr <marcorr@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with
 mirrors

On 2/11/22 20:36, Peter Gonda wrote:
> +	list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
> +	list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
> +				 mirror_entry) {

Is list_for_each_entry_safe actually necessary here?  (It would be if 
you used list_add/list_del instead of list_cut_before).

> +		kvm_get_kvm(dst_kvm);
> +		kvm_put_kvm(src_kvm);
> +		mirror->enc_context_owner = dst_kvm;
> +	}

Thanks,

Paolo