linux-kernel - Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMkAt6rLafSikpQEKkbbT8DW4OG_pDL63jPLtCFiO1NNtTRe+A@mail.gmail.com>
Date:   Mon, 14 Feb 2022 08:52:47 -0700
From:   Peter Gonda <pgonda@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm list <kvm@...r.kernel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Marc Orr <marcorr@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors

On Mon, Feb 14, 2022 at 5:57 AM Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 2/11/22 20:36, Peter Gonda wrote:
> > +     list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
> > +     list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
> > +                              mirror_entry) {
>
> Is list_for_each_entry_safe actually necessary here?  (It would be if
> you used list_add/list_del instead of list_cut_before).

 I don't think so, I think we could use list_for_each_entry here. Do
you want me to send another revision?

>
> > +             kvm_get_kvm(dst_kvm);
> > +             kvm_put_kvm(src_kvm);
> > +             mirror->enc_context_owner = dst_kvm;
> > +     }
>
> Thanks,
>
> Paolo
>