linux-kernel - Re: [PATCH] mm: page_io: fix psi memory pressure error on cold swapins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220214144805.fa389f495fdfb07b40526f70@linux-foundation.org>
Date:   Mon, 14 Feb 2022 14:48:05 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, CGEL <cgel.zte@...il.com>,
        Minchan Kim <minchan@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Yu Zhao <yuzhao@...gle.com>
Subject: Re: [PATCH] mm: page_io: fix psi memory pressure error on cold
 swapins

On Mon, 14 Feb 2022 16:49:21 -0500 Johannes Weiner <hannes@...xchg.org> wrote:

> Once upon a time, all swapins counted toward memory pressure[1]. Then
> Joonsoo introduced workingset detection for anonymous pages and we
> gained the ability to distinguish hot from cold swapins[2][3]. But we
> failed to update swap_readpage() accordingly, and now we account
> partial memory pressure in the swapin path of cold memory.
> 
> Not for all situations - which adds more inconsistency: paths using
> the conventional submit_bio() and lock_page() route will not see much
> pressure - unless storage itself is heavily congested and the bio
> submissions stall. ZRAM and ZSWAP do most of the work directly from
> swap_readpage() and will see all swapins reflected as pressure.
> 
> Restore consistency by making all swapin stall accounting conditional
> on the page actually being part of the workingset.

Does this have any known runtime effects?  If not, can we
hazard a guess?