linux-kernel - Re: [ANNOUNCE] autofs 5.1.8 release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <164487880421.17471.502085345359040789@noble.neil.brown.name>
Date:   Tue, 15 Feb 2022 09:46:44 +1100
From:   "NeilBrown" <neilb@...e.de>
To:     "Ian Kent" <raven@...maw.net>
Cc:     autofs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [ANNOUNCE] autofs 5.1.8 release

On Mon, 14 Feb 2022, Ian Kent wrote:
> On Thu, 2022-02-10 at 08:59 +1100, NeilBrown wrote:
> > On Tue, 19 Oct 2021, Ian Kent wrote:
> > > Hi all,
> > > 
> > > It's time for a release, autofs-5.1.8.
> > > 
> > ...
> > > - also require TCP_REQUESTED when setting NFS port.
> > 
> > Unfortunately that last patch is buggy.  TCP_REQUESTED is masked out
> > in
> > the caller.
> 
> Mmm ... sounds like I've made a mistake there.
> I'll need to sort that out, thanks for pointing it out.
> 
> > 
> > Maybe the following is best.
> > 
> > NeilBrown
> > 
> > From: NeilBrown <neilb@...e.de>
> > Subject: [PATCH] Test TCP request correctly in nfs_get_info()
> > 
> > The TCP_REQUESTED flag is masked out by the caller, so it never gets
> > to
> > nfs_get_info().
> 
> That wasn't my intent, I'll need to look at it again.
> The case I'm trying to cover is fairly specific so I will need to
> look at it again.
> 

I'm curious: What was the case you were trying to solve??  I couldn't
guess any justification for the change.

Thanks,
NeilBrown