linux-kernel - [PATCH 1/2] PCI: fu740: fix finding GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Feb 2022 08:21:43 +0000
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     linux-kernel@...r.kernel.org, bhelgaas@...gle.comv,
        linux-pci@...r.kernel.org
Cc:     paul.walmsley@...ive.com, greentime.hu@...ive.com,
        david.abdurachmanov@...il.com,
        Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: [PATCH 1/2] PCI: fu740: fix finding GPIOs

The calls to devm_gpiod_get_optional() have the -gpios at the end of
the name. This means the pcie driver is not finding the necessary
reset or power GPOOs to allow the PCIe devices on the SiFive Unmatched
boards.

This has not been a noted bug as the PCIe probe from u-boot has been
required to get the PCIe working due to other issues with the system
setup. It could have been broken since the driver inclusion, and not
been noticed as it is not necessary for the driver to funciton.

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
 drivers/pci/controller/dwc/pcie-fu740.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 00cde9a248b5..842b7202b96e 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -259,11 +259,11 @@ static int fu740_pcie_probe(struct platform_device *pdev)
 		return PTR_ERR(afp->mgmt_base);
 
 	/* Fetch GPIOs */
-	afp->reset = devm_gpiod_get_optional(dev, "reset-gpios", GPIOD_OUT_LOW);
+	afp->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(afp->reset))
 		return dev_err_probe(dev, PTR_ERR(afp->reset), "unable to get reset-gpios\n");
 
-	afp->pwren = devm_gpiod_get_optional(dev, "pwren-gpios", GPIOD_OUT_LOW);
+	afp->pwren = devm_gpiod_get_optional(dev, "pwren", GPIOD_OUT_LOW);
 	if (IS_ERR(afp->pwren))
 		return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");
 
-- 
2.34.1