linux-kernel - Re: [RFC V2 1/6] blk: make blk-rq-qos support pluggable and modular policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <517dddb8-efd6-6b1a-fa1b-eba6f2c93119@acm.org>
Date:   Tue, 15 Feb 2022 13:23:46 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     "Wang Jianchao (Kuaishou)" <jianchao.wan9@...il.com>,
        Jens Axboe <axboe@...nel.dk>
Cc:     hch@...radead.org, Josef Bacik <jbacik@...com>,
        Tejun Heo <tj@...nel.org>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC V2 1/6] blk: make blk-rq-qos support pluggable and modular
 policy

On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
> @@ -337,6 +338,7 @@ void blk_cleanup_queue(struct request_queue *q)
>   	 * it is safe to free requests now.
>   	 */
>   	mutex_lock(&q->sysfs_lock);
> +	rq_qos_exit(q);
>   	if (q->elevator)
>   		blk_mq_sched_free_rqs(q);
>   	mutex_unlock(&q->sysfs_lock);

I think this change should be a separate patch with tag "Fixes: 
8e141f9eb803 ("block: drain file system I/O on del_gendisk")". See also 
https://lore.kernel.org/linux-block/b64942a1-0f7e-9e9c-0fd4-c35647035eaf@acm.org/

Thanks,

Bart.