linux-kernel - Re: [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb5677fc-01ac-f97f-ccf8-eb91505ad0e3@acm.org>
Date:   Tue, 15 Feb 2022 13:26:55 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     "Wang Jianchao (Kuaishou)" <jianchao.wan9@...il.com>,
        Jens Axboe <axboe@...nel.dk>
Cc:     hch@...radead.org, Josef Bacik <jbacik@...com>,
        Tejun Heo <tj@...nel.org>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular

On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
> diff --git a/block/Makefile b/block/Makefile
> index f38eaa612929..f6a3995af285 100644
> --- a/block/Makefile
> +++ b/block/Makefile
> @@ -17,7 +17,8 @@ obj-$(CONFIG_BLK_DEV_BSGLIB)	+= bsg-lib.o
>   obj-$(CONFIG_BLK_CGROUP)	+= blk-cgroup.o
>   obj-$(CONFIG_BLK_CGROUP_RWSTAT)	+= blk-cgroup-rwstat.o
>   obj-$(CONFIG_BLK_DEV_THROTTLING)	+= blk-throttle.o
> -obj-$(CONFIG_BLK_CGROUP_IOPRIO)	+= blk-ioprio.o
> +io-prio-y 			:= blk-ioprio.o
> +obj-$(CONFIG_BLK_CGROUP_IOPRIO)	+= io-prio.o
>   obj-$(CONFIG_BLK_CGROUP_IOLATENCY)	+= blk-iolatency.o
>   obj-$(CONFIG_BLK_CGROUP_IOCOST)	+= blk-iocost.o
>   obj-$(CONFIG_MQ_IOSCHED_DEADLINE)	+= mq-deadline.o

Is the above change really necessary?

> +static int blk_ioprio_init(struct request_queue *q);
>   static struct rq_qos_ops blkcg_ioprio_ops = {

Please insert a blank line between a function declaration and a 
structure definition.

Thanks,

Bart.