linux-kernel - Re: [PATCH] ath9k: use hw_random API instead of directly dumping into random.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALjTZvZb9oFLT5zOvxgt3ZrsOc+id8o3KXGFJobO6ks6UZtgWg@mail.gmail.com>
Date:   Tue, 15 Feb 2022 22:55:18 +0000
From:   Rui Salvaterra <rsalvaterra@...il.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     miaoqing@...eaurora.org, Jason Cooper <jason@...edaemon.net>,
        "Sepehrdad, Pouyan" <pouyans@....qualcomm.com>,
        ath9k-devel <ath9k-devel@....qualcomm.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        LKML <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ath9k: use hw_random API instead of directly dumping into random.c

Hi, Jason,

On Tue, 15 Feb 2022 at 22:44, Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Hardware random number generators are supposed to use the hw_random
> framework. This commit turns ath9k's kthread-based design into a proper
> hw_random driver.
>
> This compiles, but I have no hardware or other ability to determine
> whether it works. I'll leave further development up to the ath9k
> and hw_random maintainers.
>
> Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

[patch snipped]

On my laptop, with a…

02:00.0 Network controller: Qualcomm Atheros AR9462 Wireless Network
Adapter (rev 01)

… I have the following…

rui@...andale:~$ cat /sys/devices/virtual/misc/hw_random/rng_available
ath9k
rui@...andale:~$ cat /sys/devices/virtual/misc/hw_random/rng_current
ath9k
rui@...andale:~$

… and sure enough, /dev/hwrng is created and outputs a stream of
random data, as expected. I haven't done any serious randomness
quality testing, but it should be the same as the one produced by the
original code. I consider this patch thus

Tested-by: Rui Salvaterra <rsalvaterra@...il.com>

Thanks,
Rui