linux-kernel - Re: [PATCH v3 3/3] input: ps2-gpio: enforce GPIOs flag open drain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Feb 2022 14:56:40 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Danilo Krummrich <danilokrummrich@...develop.de>
Cc:     krzysztof.kozlowski@...onical.com, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linus.walleij@...aro.org
Subject: Re: [PATCH v3 3/3] input: ps2-gpio: enforce GPIOs flag open drain

On Tue, Feb 15, 2022 at 07:08:29PM +0100, Danilo Krummrich wrote:
> The PS/2 bus defines the data and clock line be open drain, therefore
> for both enforce the particular GPIO flags in the driver.
> 
> Without enforcing to flag at least the clock gpio as open drain we run
> into the following warning:
> 
> WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90
> 
> gpiochip_enable_irq() warns on a GPIO being configured as output while
> serving as IRQ source without being flagged as open drain.
> 
> Signed-off-by: Danilo Krummrich <danilokrummrich@...develop.de>

Applied, thank you.

-- 
Dmitry